Review main Merged

97130[TASK] Assert both cyclic dependency failures

Wouter Wolters CR +2 V +2 Easy +4 −2 updated 11/10/26, 22:13

Commit message

Assert the first cyclic service resolution fails before checking the
second resolution independently. Keep the service presence assertion
and verify the cyclic-dependency message for both attempts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/25/26, 10:23

  2. Wouter Wolters updated the commit message in patch set 2 11/10/26, 20:26

  3. Wouter Wolters marked it ready for review 11/10/26, 20:27

  4. Wouter Wolters wrote 11/10/26, 20:27

    Unset private
  5. core-ci voted on patch set 2 V +1 11/10/26, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113953

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/10/26, 21:34

  7. Benni Mack voted on patch set 2 CR +2 V +2 11/10/26, 22:13

  8. Benni Mack merged patch set 3 11/10/26, 22:13