Review main Merged

97144[TASK] Strengthen password generation tests

Wouter Wolters CR +2 V +2 Easy +28 −21 updated 10/28/26, 15:29

Commit message

Assert exact password lengths and allowed character sets, use the
supported length option and reject constant output across repeated
samples. Rename the disabled-character-set case to describe rejection.
This is a regression guard, not a cryptographic proof.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/25/26, 14:02

  2. Wouter Wolters uploaded patch set 2 10/25/26, 16:06

  3. Wouter Wolters updated the commit message in patch set 3 10/26/26, 21:13

  4. Wouter Wolters marked it ready for review 10/26/26, 21:13

  5. Wouter Wolters wrote 10/26/26, 21:13

    Unset private
  6. core-ci voted on patch set 3 V +1 10/26/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112613

  7. Benni Mack voted on patch set 3 CR +2 V +2 10/28/26, 15:29

  8. Benni Mack merged patch set 4 10/28/26, 15:29