Review main Abandoned

97157[TASK] Decide module access with the authorization checker

Benni Mack CR 0 V 0 Normal +84 −2 updated 11/17/26, 15:49

Commit message

ModuleProvider::accessGranted() now asks the authorization checker
whether the principal of the request may access a module, when the
given backend user is that principal and the module uses one of the
access values of TYPO3 Core: "user", "admin" or "systemMaintainer".
The ModuleVoter answers that as the access gates of TYPO3 Core did, a
functional test compares both for every registered module.

The access of any other user, of a request without principal and of a
module with an access gate of an extension is still decided by the
access gates. The workspace restriction of a module is checked before,
as it depends on the current workspace instead of a grant.

This is the first call site moved onto the authorization checker. As
a voter can deny access, an extension can now restrict the access to
backend modules with a voter of its own.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 3

Review log 1220

  1. Benni Mack uploaded patch set 1 10/25/26, 14:19

  2. core-ci voted on patch set 1 V +1 10/25/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112514

  3. Oli Bartsch rebased onto patch set 2 V +1 10/25/26, 19:39

  4. core-ci voted on patch set 2 V +1 10/25/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112544

  5. Benni Mack rebased onto patch set 3 V +1 10/26/26, 19:41

  6. core-ci voted on patch set 3 V +1 10/26/26, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112611

  7. Oliver Klee voted on patch set 3 V +1 10/26/26, 21:09

  8. Benni Mack rebased onto patch set 4 V +1 11/03/26, 14:43

  9. core-ci voted on patch set 4 V +1 11/03/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113167

  10. Benni Mack rebased onto patch set 5 V +1 11/09/26, 10:12

  11. core-ci voted on patch set 5 V +1 11/09/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113643

  12. Benni Mack rebased onto patch set 6 V +1 11/10/26, 20:26

  13. core-ci voted on patch set 6 V +1 11/10/26, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113950

  14. Oliver Klee voted on patch set 6 V +1 11/11/26, 08:40

  15. Benni Mack rebased onto patch set 7 V +1 11/13/26, 14:31

  16. core-ci voted on patch set 7 V +1 11/13/26, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114342

  17. Benni Mack rebased onto patch set 8 V +1 11/13/26, 19:02

  18. Benni Mack rebased onto patch set 9 11/13/26, 20:59

  19. core-ci voted on patch set 9 V +1 11/13/26, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114400

  20. Benni Mack abandoned the change 11/17/26, 15:49