97168[BUGFIX] Correct finisher config for SimpleContactForm.yaml example
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Josua Vogel +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Josua Vogel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1923
-
Markus Klein uploaded patch set 1 10/26/26, 19:03
-
core-ci voted on patch set 1 V +1 10/26/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112603
-
Josua Vogel updated the commit message in patch set 2
V +110/26/26, 19:16 -
core-ci voted on patch set 2 V +1 10/26/26, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112604
-
Wouter Wolters commented on patch set 1 10/26/26, 19:43
provide -
Wouter Wolters commented on patch set 2 10/26/26, 19:44
Reply
Done -
Garvin Hicking commented on patch set 2 10/26/26, 20:29
SimpleContactForm.yaml:9I would not change the default subject here for v14; people might have set mail filtering with this?SimpleContactForm.yaml:11```suggestion your.company.marketing@example.com: 'Your company name' ```SimpleContactForm.yaml:11```suggestion your.company.recipientg@example.com: 'Your Company name' ```SimpleContactForm.yaml:12```suggestion senderAddress: 'your.company.sender@example.com' ```SimpleContactForm.yaml:13```suggestion senderName: 'Your company name - contact form' ``` -
Markus Klein commented on patch set 2 10/26/26, 21:08
SimpleContactForm.yaml:9ReplyMaybe I'm mistaken, but when I create a new form this is taken as a source to copy from. So this is just a template not the actual form, right? -
Josua Vogel commented on patch set 2 10/26/26, 21:13
SimpleContactForm.yaml:9ReplyYes, that’s just a template. I see no problem with changing the subject -
Garvin Hicking commented on patch set 2 10/26/26, 21:20
SimpleContactForm.yaml:9ReplyI mean you would expect creating new forms follow the prior templates on a v14 setup as an editor?! If you all disagree I can let it go. ;) -
Markus Klein commented on patch set 2 10/27/26, 10:25
SimpleContactForm.yaml:9ReplyNot sure what you mean Garvin. I myself created a new form in a brand new v14 and used this template. I was astonished that it can be so terribly wrong. -
Garvin Hicking commented on patch set 2 10/27/26, 10:38
SimpleContactForm.yaml:9ReplyI think I understand now, methodically the message subject was wrong too, because it's not really "Your" message the receiver of a form recieves, but "Their message". So your new subject fits. Resolving this. 😊 -
Garvin Hicking commented on patch set 2 10/27/26, 10:39
SimpleContactForm.yaml:11```suggestion your.company.recipient@example.com: 'Your company name' ```SimpleContactForm.yaml:11ReplyDoneSimpleContactForm.yaml:11ReplyDone -
Markus Klein commented on patch set 3
V +110/27/26, 11:48Published edit on patch set 2. -
Markus Klein commented on patch set 4 10/27/26, 11:49
Published edit on patch set 3. -
Markus Klein commented on patch set 4 10/27/26, 11:50
SimpleContactForm.yaml:11ReplyFix applied.SimpleContactForm.yaml:12ReplyDoneSimpleContactForm.yaml:13ReplyDone -
core-ci voted on patch set 3 V +1 10/27/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112646
-
core-ci voted on patch set 4 V +1 10/27/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112647
-
Garvin Hicking voted on patch set 4 CR +1 V +1 10/27/26, 12:06
-
Josua Vogel voted on patch set 4 CR +1 V +1 10/27/26, 14:17
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/06/26, 00:56
-
Benni Mack voted on patch set 4 CR +2 V +2 11/06/26, 05:52
-
Benni Mack merged patch set 5 11/06/26, 05:52