Review main Merged

97170[BUGFIX] Fix sliding window pagination defaults

Wouter Wolters CR +2 V +2 Easy +31 −4 updated 11/11/26, 19:57

Commit message

Default the maximum number of links to ten so constructing a sliding
window pagination without a limit produces valid page numbers.
Non-positive limits also fall back to ten links.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Wouter Wolters uploaded patch set 1 10/26/26, 21:43

  2. core-ci voted on patch set 1 V +1 10/26/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112617

  3. Simon Schaufelberger commented on patch set 1 CR -1 10/26/26, 22:55

    when you backport something to 14.3, the important rest file also needs to go into the correct folder
  4. Wouter Wolters uploaded patch set 2 CR -1 V +1 11/10/26, 20:19

  5. Wouter Wolters commented on patch set 2 11/10/26, 20:19

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/10/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113944

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 11/10/26, 22:42

  8. Josua Vogel voted on patch set 2 CR +1 V +1 11/11/26, 07:22

  9. Garvin Hicking commented on patch set 2 CR -1 11/11/26, 07:27

    Important-111246-UseValidDefaultForSlidingWindowPagination.rst:14

    I think we don't need to document this bugfix as important. This will make the changelogs too noisy if we go down that path.
  10. Josua Vogel commented on patch set 2 11/11/26, 07:37

    Important-111246-UseValidDefaultForSlidingWindowPagination.rst:14 Reply

    True, AI loves Important changelogs 😄 The current default value produces the bug, so it´s not necessary to inform about the new default.
  11. Oliver Klee voted on patch set 2 V +1 11/11/26, 08:38

  12. Josua Vogel uploaded patch set 3 CR +1 V +1 11/11/26, 13:55

  13. Josua Vogel commented on patch set 3 CR +1 V +1 11/11/26, 13:55

    Important-111246-UseValidDefaultForSlidingWindowPagination.rst:14 Reply

    Done
  14. core-ci voted on patch set 3 V +1 11/11/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114092

  15. Garvin Hicking voted on patch set 3 CR +2 V +2 11/11/26, 18:59

  16. Garvin Hicking merged patch set 4 11/11/26, 19:57