Review main Merged

97173[TASK] Add tests for null persistence

Daniel Windloff CR +2 V +2 Hard +422 −0 updated 10/30/26, 16:15

Commit message

Add tests to `EditDocumentController` and
`ContextualRecordEditController` checking `null`
in DataHandler's persistence.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1013

  1. Daniel Windloff uploaded patch set 1 10/27/26, 05:35

  2. Daniel Windloff wrote 10/27/26, 05:36

    Topic set to DataHandler
  3. core-ci voted on patch set 1 V -1 10/27/26, 05:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112634

  4. Daniel Windloff uploaded patch set 2 V -1 10/27/26, 05:52

  5. core-ci voted on patch set 2 V +1 10/27/26, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112635

  6. Oliver Klee voted on patch set 2 V +1 10/27/26, 10:50

  7. Simon Schaufelberger commented on patch set 2 10/27/26, 11:11

    ContextualRecordEditControllerTest.php:41

    not needed

    ContextualRecordEditControllerTest.php:94

    data provider before the test method please

    EditDocumentControllerTest.php:433

    data provider before test methods please

    EditDocumentControllerTest.php:519

    remove empty line
  8. Daniel Windloff uploaded patch set 3 V +1 10/29/26, 06:15

  9. Daniel Windloff commented on patch set 3 10/29/26, 06:15

    ContextualRecordEditControllerTest.php:41 Reply

    Done

    ContextualRecordEditControllerTest.php:94 Reply

    Done

    EditDocumentControllerTest.php:433 Reply

    Done

    EditDocumentControllerTest.php:519 Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/29/26, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112777

  11. Oliver Klee voted on patch set 3 V +1 10/29/26, 10:51

  12. Benni Mack voted on patch set 3 CR +2 V +2 10/30/26, 16:15

  13. Benni Mack merged patch set 4 10/30/26, 16:15