Review main Merged

97176[BUGFIX] Render multiple file uploads in form email finishers

Josua Vogel CR +2 V +2 Normal +66 −8 updated 10/28/26, 13:04

Commit message

A FileUpload or ImageUpload element with "multiple" enabled holds an
ObjectStorage. RenderFormValueViewHelper flags such a value as multi
value, but FileUpload::processElementValue() imploded the file names
into a single string. The email finisher templates iterate the
processed value of multi value elements, so the submission ended in
an InvalidArgumentValueException of the ForViewHelper and no mail was
sent.

The processed value of a multiple upload is now a list of file names,
matching what FormValueResolver returns for an ObjectStorage. A single
upload still resolves to its file name.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Josua Vogel uploaded patch set 1 10/27/26, 19:57

  2. core-ci voted on patch set 1 V +1 10/27/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112655

  3. Josua Vogel uploaded patch set 2 V +1 10/28/26, 10:32

  4. core-ci voted on patch set 2 V +1 10/28/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112704

  5. Benni Mack voted on patch set 2 CR +1 V +1 10/28/26, 12:36

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 10/28/26, 13:04

  7. Oli Bartsch merged patch set 3 10/28/26, 13:04