Review main Merged

97178[BUGFIX] Let editors publish new root-level records

Garvin Hicking CR +2 V +2 Easy +47 −1 updated 10/30/26, 13:32

Commit message

Publishing a record that was created in a workspace checks the show
permission of its page. For records on root level (pid=0),
`DataHandler::hasPageContextPermission()` answers this with the
"ignoreRootLevelRestriction" setting of the table passed in. Since
patch #107432 the check for new placeholders passes "pages" instead
of the table of the record, which never ignores the root-level
restriction.

Non-admin editors could therefore not publish new records of tables
like sys_file_metadata, which allow root-level editing since #106569,
and the workspace module logged "You cannot publish a record you do not
have edit and show permissions for". Changed versions of existing
records were not affected, since that check already used the table of
the record.

The check now passes the table of the record, as all other permission
checks in `DataHandlerHook::version_swap()` do.

A functional test covers a non-admin editor publishing a new file
metadata translation.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 710

  1. Garvin Hicking uploaded patch set 1 10/27/26, 20:26

  2. Garvin Hicking uploaded patch set 2 10/27/26, 20:35

  3. core-ci voted on patch set 2 V -1 10/27/26, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112659

  4. Ines Willenbrock voted on patch set 2 CR +1 10/27/26, 20:51

  5. core-ci voted on patch set 1 V +1 10/27/26, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112658

  6. Garvin Hicking uploaded patch set 3 CR +1 V -1 10/30/26, 11:44

  7. core-ci voted on patch set 3 V +1 10/30/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112868

  8. Benni Mack voted on patch set 3 CR +1 V +1 10/30/26, 12:10

  9. Garvin Hicking voted on patch set 3 CR +2 V +2 10/30/26, 13:32

  10. Garvin Hicking merged patch set 4 10/30/26, 13:32