Review main Merged

97179[BUGFIX] Encode TOTP issuer consistently in otpauth URI

Oli Bartsch CR +2 V +2 Easy +11 −1 updated 10/27/26, 21:53

Commit message

Totp::getTotpAuthUrl() applied htmlspecialchars() to the issuer before
http_build_query() percent-encoded it for the "issuer" query parameter,
while the label prefix only used rawurlencode(). If the sitename
contained &, <, >, " or ', the "issuer" parameter therefore carried an
HTML entity such as "&amp;" and no longer matched the label prefix, as
required by the Key Uri Format.

The HTML escaping is dropped. The URI is fully percent-encoded, and the
value is escaped by Fluid where it is rendered in the setup view.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 10/27/26, 20:40

  2. Josua Vogel voted on patch set 1 CR +1 10/27/26, 20:47

  3. core-ci voted on patch set 1 V +1 10/27/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112660

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/27/26, 20:57

  5. Oliver Klee voted on patch set 1 CR +1 V +1 10/27/26, 21:11

  6. Wouter Wolters voted on patch set 1 CR +1 V +1 10/27/26, 21:31

  7. Oli Bartsch voted on patch set 1 CR +2 V +2 10/27/26, 21:53

  8. Oli Bartsch merged patch set 2 10/27/26, 21:53