Review main Merged

97183[TASK] Declare CRLF constant for PHPStan

Oli Bartsch CR +2 V +2 Easy +1 −0 updated 10/28/26, 08:02

Commit message

PHPStan 2.3.3 no longer discovers the CRLF constant from its
conditional define() in SystemEnvironmentBuilder, which breaks
the nightly composerInstallMax builds with 328 constant.notFound
errors.

Declare CRLF in the PHPStan bootstrap file next to LF and CR.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 10/28/26, 07:52

  2. Josua Vogel voted on patch set 1 CR +1 10/28/26, 07:55

  3. core-ci voted on patch set 1 V +1 10/28/26, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112681

  4. Benni Mack voted on patch set 1 CR +2 V +2 10/28/26, 08:02

  5. Benni Mack merged patch set 2 10/28/26, 08:02