Review main Abandoned

97184[TASK] Raise phpstan/phpstan to ^2.3.3

Benni Mack CR 0 V 0 Easy +7 −6 updated 10/28/26, 08:02

Commit message

PHPStan 2.3.3 does not correctly detect conditional constant
definitions such as the one for CRLF in SystemEnvironmentBuilder,
which uses "defined('CRLF') ?: define(...)". As a result, every
usage of CRLF is reported as an unknown constant.

CRLF is now defined in the PHPStan bootstrap file, next to LF and CR,
which removes these false positives.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 3

  1. Benni Mack uploaded patch set 1 10/28/26, 07:56

  2. Benni Mack uploaded patch set 2 10/28/26, 07:57

  3. Benni Mack abandoned the change 10/28/26, 08:02

    not needed