Review 14.3 Merged

97195[BUGFIX] Revert slug changes of all pages saved together

Oli Bartsch CR +2 V +2 Hard +363 −36 updated 10/28/26, 15:51

Commit message

When the slugs of several pages were changed in one DataHandler call,
e.g. via "Edit columns" in the record list, the "Slugs updated and
redirects created" notification only reverted the page processed last.

SlugService sends one update signal per changed page, but
BackendUtility::setUpdateSignal() stores signals by their name. Each
page therefore overwrote the notification payload of the previous one.

SlugService now collects the payloads of all pages changed within the
request and stores them in one update signal. The
DispatchNotificationHook dispatches the unchanged slug changed event
for each page, and the event handler combines the events into a single
notification, whose actions revert the changes of all pages, the most
recent first. One notification per page is not an option, because a
revert reloads the backend and drops all other notifications.

Since a combined notification is meaningless without saying what it
reverts, the payload now carries the changed page with its old and new
slug, and the number of updated sub-pages and created redirects. The
notification names the changed pages and sums up what was changed
along with them. No notification is sent anymore if neither sub-pages
were updated nor redirects were created, since there is nothing to
report besides the change the user just made.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Oli Bartsch commented on patch set 1 10/28/26, 13:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/28/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112712

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/28/26, 15:51

  4. Oli Bartsch merged patch set 2 10/28/26, 15:51