97197[BUGFIX] Avoid unbounded recursion in SuggestWizardDefaultReceiver
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/97/97197/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/97/97197/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php1+34 −25
- typo3/sysext/backend/Tests/Functional/Form/Wizard/Fixtures/pages_suggest.csvnew+124 −0
- typo3/sysext/backend/Tests/Functional/Form/Wizard/Fixtures/tt_content_suggest_access.csvnew+142 −0
- typo3/sysext/backend/Tests/Functional/Form/Wizard/SuggestWizardDefaultReceiverTest.php1+58 −0
Review log 35
-
Johannes Schlier uploaded patch set 1 10/28/26, 15:10
-
core-ci voted on patch set 1 V +1 10/28/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112728
-
Oli Bartsch commented on patch set 1 10/28/26, 18:32
SuggestWizardDefaultReceiverTest.php:48Unresolvedboth tests run as admin, so `checkRecordAccess()` never rejects a row. Would be goo to have at least one non-admin test, where the first 50+ matches are inaccessible and later accessible ones must still be returned, plus one that checks scanning stops at the cap. -
Johannes Schlier uploaded patch set 2
V +111/16/26, 16:36 -
core-ci voted on patch set 2 V +1 11/16/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114638
SuggestWizardDefaultReceiver.php:180Unresolved