97207[BUGFIX] SQL parser handles float UNSIGNED now
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/07/97207/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/07/97207/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Georg Ringer +1
-
Verified V +1 Needs a vote
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/DecimalDataType.php6+3 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/FloatDataType.php+3 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/FixedPointTypesTest.php+18 −8
Review log 911
-
Markus Klein uploaded patch set 1 10/28/26, 20:17
-
core-ci voted on patch set 1 V +1 10/28/26, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112751
-
Oli Bartsch commented on patch set 1 10/28/26, 20:53
DecimalDataType.php:32`FloatDataType` (the parent of `DoubleDataType` and `RealDataType`) also receives the numeric options and never calls `setUnsigned()`, so `FLOAT UNSIGNED` stays signed as well. Suggest to apply the same fix there. -
Markus Klein commented on patch set 1 10/28/26, 22:20
DecimalDataType.php:32ReplyIndeed. Yes, this should be added there as well then. Will do tomorrowDecimalDataType.php:32ReplyActually, I simply pushed the patch and waited for failing tests. ;-) Clearly we need coverage for that. -
Markus Klein uploaded patch set 2
V +110/30/26, 07:43 -
core-ci voted on patch set 2 V +1 10/30/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112835
-
Markus Klein commented on patch set 2 10/31/26, 20:43
DecimalDataType.php:32ReplyDoneDecimalDataType.php:32ReplyDone -
Georg Ringer voted on patch set 2 CR +1 V +1 11/10/26, 08:07
-
Benni Mack commented on patch set 2 11/13/26, 07:30
Two things: 1. FloatingPointTypesTest should get FLOAT/DOUBLE/REAL UNSIGNED cases, the float part is untested. 2. On existing MySQL/MariaDB installations the DB analyzer now suggests ALTER … UNSIGNED for such columns, and that fails with "Out of range value" if negative values exist. -
Markus Klein commented on patch set 2 11/13/26, 07:51
Reply
1.) will check that 2.) That's unexpected. If the column was declared unsigned manually, that was done on purpose, so whatever is stored in there is most likely not negative. If you really have that case, then you're setup was already wrong before and worked only, because our parse failed to parse this. I'd say that's okay. -
Benni Mack commented on patch set 2 11/13/26, 08:19
Reply Unresolved
2. I don't have this scenario IRL, I have fumbled around with this locally, so I'm totally fine with this change.
DecimalDataType.php:32