Review main Merged

97208[BUGFIX] Respect field access for the record list hide button

Wolfgang Klinger CR +2 V +2 Normal +65 −1 updated 10/29/26, 21:49

Commit message

The record list decided whether to render the hide/unhide button
with an inverted check of the "exclude" flag of the disabled field.
Non-admin users did not get the button for a disabled field without
"exclude", but got it for an excluded field they had no access to.

The button is now rendered if the field is not excluded or the user
has access to it, like in the page module and the context menu.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Wolfgang Klinger uploaded patch set 1 10/29/26, 05:59

  2. core-ci voted on patch set 1 V +1 10/29/26, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112776

  3. Daniel Windloff voted on patch set 1 CR +1 V +1 10/29/26, 06:29

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/29/26, 06:30

  5. Oli Bartsch commented on patch set 1 10/29/26, 08:45

    DatabaseRecordListAsUserTest.php:32

    Why do we add a new test class instead of just extending existing `DatabaseRecordListTest`? In the long run this might IMO just slow down CI and also has no real benefit.
  6. Wolfgang Klinger commented on patch set 1 10/29/26, 08:56

    DatabaseRecordListAsUserTest.php:32 Reply

    I followed existing patterns, the available class tests only with admins. But propose a better solution.
  7. Oli Bartsch commented on patch set 1 10/29/26, 11:50

    DatabaseRecordListAsUserTest.php:32 Reply

    Could just be added to the other Test class while importing an editor csv in the corresponding tests with, e.g. ``` $this->importCSVDataSet(__DIR__ . '/../Fixtures/be_users_with_editor.csv'); .... ```
  8. Wolfgang Klinger uploaded patch set 2 CR +1 V +1 10/29/26, 12:45

  9. core-ci voted on patch set 2 V +1 10/29/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112799

  10. Daniel Windloff voted on patch set 2 CR +1 V +1 10/29/26, 16:06

  11. Oli Bartsch commented on patch set 2 CR +2 V +2 10/29/26, 21:49

    DatabaseRecordListAsUserTest.php:32 Reply

    Done
  12. Oli Bartsch merged patch set 3 10/29/26, 21:49