Review main Merged

97213[BUGFIX] Keep module menu state on double click

Peter Neumann CR +2 V +2 Easy +20 −1 updated 10/29/26, 19:07

Commit message

Bootstrap's Collapse ignores show() and hide() while a transition
is still running. A fast second click on a module menu group was
therefore swallowed, but the module menu still flipped
aria-expanded, the group classes and the persisted state, so the
indicator pointed the wrong way.

Toggling a group is now skipped while its collapse transition is
running, so the menu state always reflects what is shown.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Peter Neumann uploaded patch set 1 10/29/26, 17:09

  2. core-ci voted on patch set 1 V +1 10/29/26, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112801

  3. Oli Bartsch commented on patch set 1 CR +1 V +1 10/29/26, 17:34

    Thank you!
  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/29/26, 17:39

  5. Daniel Windloff voted on patch set 1 CR +1 V +1 10/29/26, 17:42

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 10/29/26, 19:07

  7. Oli Bartsch merged patch set 2 10/29/26, 19:07