Review main Merged

97216[BUGFIX] Let the honeypot render its own attributes

Lina Wolf CR +2 V +2 Normal +104 −1 updated 11/17/26, 21:07

Commit message

The honeypot partial spent additionalAttributes on a literal
aria-hidden, so the three editors of the element writing into
fluidAdditionalAttributes were discarded. It now reads that property
and carries the ARIA state in the ViewHelper's aria argument, as every
other frontend partial does, and autocomplete off becomes a default so
a form filler no longer trips the HoneypotValidator. The
renderAsHiddenField branch stays untouched, because an input of type
hidden must not carry autocomplete.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 810

  1. Lina Wolf uploaded patch set 1 10/29/26, 18:02

  2. core-ci voted on patch set 1 V +1 10/29/26, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112805

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/09/26, 20:57

  4. Josua Vogel uploaded patch set 2 CR +1 V +1 11/10/26, 13:01

  5. Josua Vogel voted on patch set 2 CR +1 V +1 11/10/26, 13:01

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/10/26, 13:02

  7. core-ci voted on patch set 2 V +1 11/10/26, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113898

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/14/26, 20:16

  9. Georg Ringer voted on patch set 2 CR +2 V +2 11/17/26, 21:07

  10. Georg Ringer merged patch set 3 11/17/26, 21:07