Review main Merged

97221[BUGFIX] Show default language in tiles of the Sites overview

Oli Bartsch CR +2 V +2 Normal +121 −1 updated 11/01/26, 15:44

Commit message

The tiles view of the Sites module overview rendered flag and title
of the language with key 0 of Site::getAllLanguages(). As the list is
keyed by languageId, this failed with a TypeError for sites without
language 0, and the module could not be opened at all.

The default language of the site is now used instead.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Oli Bartsch uploaded patch set 1 10/29/26, 22:37

  2. core-ci voted on patch set 1 V +1 10/29/26, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112814

  3. Benni Mack voted on patch set 1 CR +1 V +1 10/30/26, 12:10

  4. Oli Bartsch rebased onto patch set 2 CR +1 V +1 10/30/26, 14:53

  5. Oli Bartsch commented on patch set 2 10/30/26, 14:53

    Rebased onto the merged #110913 (soft-fail for broken site configurations) as the base for #97222, no changes to this patch.
  6. core-ci voted on patch set 2 V +1 10/30/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112885

  7. Benni Mack voted on patch set 2 CR +1 V +1 10/30/26, 16:20

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 11/01/26, 15:44

  9. Oli Bartsch merged patch set 3 11/01/26, 15:44