Review main Merged

97223[BUGFIX] Store 0 for emptied integer group fields on discard

Oli Bartsch CR +2 V +2 Easy +26 −5 updated 10/31/26, 09:34

Commit message

When a workspace record is discarded, DataHandler removes references to
it from non-MM group fields of other records. The reduced CSV list was
written with a raw QueryBuilder set(), which binds the value as string.
If the list became empty, an empty string was written into integer
columns like pages.shortcut, which fails on MariaDB/MySQL strict mode
and PostgreSQL with "Incorrect integer value: ''".

The reduced value is now passed through
insertUpdateDB_preprocessBasedOnFieldType(), which converts empty
strings to 0 for integer columns, and is stored using
Connection::update(), which binds values according to the column types.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/30/26, 06:13

  2. core-ci voted on patch set 1 V +1 10/30/26, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112831

  3. Benni Mack commented on patch set 1 CR +1 V +1 10/30/26, 10:08

    This is great. I think this also fixes another issue on forge (which I don't find)
  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/30/26, 21:32

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/31/26, 09:34

  6. Oli Bartsch merged patch set 2 10/31/26, 09:34