Review main Merged

97226[BUGFIX] Publish from the workspace preview again

Matthias Vogel CR +2 V +2 Normal +111 −1 updated 11/02/26, 16:17

Commit message

Since the "publish" command of the DataHandler, the workspace preview
sends "publishPageCollectionExecute" for the stage "Publish". The
preview calls its own AJAX route, whose controller action did not
know that method and answered "Not implemented". The action of the
preview now knows it, and the one of the Workspaces module, which
never sends it, no longer does. Publishing stays subject to the
publish access of the editor.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Matthias Vogel uploaded patch set 1 10/30/26, 09:10

  2. core-ci voted on patch set 1 V +1 10/30/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112837

  3. Matthias Vogel marked it ready for review 10/30/26, 09:30

  4. Oli Bartsch commented on patch set 1 10/30/26, 10:46

    WorkspacesAjaxController.php:89

    This is now unused, since only `preview.ts` sends it via `workspace_preview`.

    WorkspacesAjaxControllerTest.php:39

    The new test only runs as admin. Could you add a case with a non-admin workspace member without publish rights calling `preview()` and assert that the live record stays unchanged? The patch adds a publishing entry point to a route without module restriction, so this would protect the publish gate against later refactorings.
  5. Matthias Vogel uploaded patch set 2 V +1 10/30/26, 12:48

  6. Matthias Vogel commented on patch set 2 10/30/26, 12:50

    WorkspacesAjaxController.php:89 Reply

    remove it.

    WorkspacesAjaxControllerTest.php:39 Reply

    Added more tests.
  7. core-ci voted on patch set 2 V +1 10/30/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112876

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 11/02/26, 08:48

  9. Oli Bartsch commented on patch set 2 CR +2 V +2 11/02/26, 16:17

    WorkspacesAjaxController.php:89 Reply

    Done

    WorkspacesAjaxControllerTest.php:39 Reply

    Done
  10. Oli Bartsch merged patch set 3 11/02/26, 16:17