97226[BUGFIX] Publish from the workspace preview again
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 3
Review log 810
-
Matthias Vogel uploaded patch set 1 10/30/26, 09:10
-
core-ci voted on patch set 1 V +1 10/30/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112837
-
Matthias Vogel marked it ready for review 10/30/26, 09:30
-
Oli Bartsch commented on patch set 1 10/30/26, 10:46
WorkspacesAjaxControllerTest.php:39The new test only runs as admin. Could you add a case with a non-admin workspace member without publish rights calling `preview()` and assert that the live record stays unchanged? The patch adds a publishing entry point to a route without module restriction, so this would protect the publish gate against later refactorings. -
Matthias Vogel uploaded patch set 2
V +110/30/26, 12:48 -
Matthias Vogel commented on patch set 2 10/30/26, 12:50
WorkspacesAjaxController.php:89Replyremove it.WorkspacesAjaxControllerTest.php:39ReplyAdded more tests. -
core-ci voted on patch set 2 V +1 10/30/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112876
-
Benjamin Kott voted on patch set 2 CR +1 V +1 11/02/26, 08:48
-
Oli Bartsch commented on patch set 2 CR +2 V +2 11/02/26, 16:17
WorkspacesAjaxController.php:89ReplyDoneWorkspacesAjaxControllerTest.php:39ReplyDone -
Oli Bartsch merged patch set 3 11/02/26, 16:17
WorkspacesAjaxController.php:89