Review main Merged

97232[BUGFIX] Allow redirects of all base variant hosts

Oli Bartsch CR +2 V +2 Normal +138 −19 updated 11/02/26, 20:22

Commit message

The source hosts an editor is allowed to see and edit redirects for
were collected from the bases of the accessible site languages. Those
bases are resolved when the site is loaded and use the first base
variant matching the current request. With the backend running on an
alternative entry point, only the host of that variant was allowed,
so redirects of the main entry point host were hidden and could not
be edited or saved anymore, and vice versa.

The permission check now uses the hosts of the configured base and
all base variants of the sites and accessible languages the editor
has a webmount in. The source host value picker still only offers
the hosts resolved in the current context, so it does not list hosts
of other application contexts.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oli Bartsch uploaded patch set 1 10/30/26, 10:14

  2. core-ci voted on patch set 1 V -1 10/30/26, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112845

  3. core-ci voted on patch set 1 V +1 10/30/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112845

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/30/26, 12:35

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/02/26, 19:22

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 11/02/26, 20:22

  7. Oli Bartsch merged patch set 2 11/02/26, 20:22