Review 14.3 Merged

97233[BUGFIX] Keep original file when extracting plain text

Benni Mack CR +2 V +2 Normal +47 −15 updated 10/30/26, 10:51

Commit message

PlainTextExtractor read the file through getForLocalProcessing(false)
and removed the returned path afterwards whenever its base name
differed from the name of the file, assuming it was a temporary copy
of a remote file. For a local storage this path is the original file,
which got deleted if the name stored in sys_file differed from the
name in the storage.

The text is now read with getContents(), which works for local and
remote storages and does not leave a temporary file behind.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack commented on patch set 1 10/30/26, 10:15

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/TextExtraction/PlainTextExtractor.php
  2. Benni Mack commented on patch set 2 10/30/26, 10:16

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 10/30/26, 10:16

  4. core-ci voted on patch set 1 V -1 10/30/26, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112847

  5. core-ci voted on patch set 2 V -1 10/30/26, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112848

  6. Benni Mack commented on patch set 3 V -1 10/30/26, 10:39

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 10/30/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112850

  8. Benni Mack voted on patch set 3 CR +2 V +2 10/30/26, 10:51

  9. Benni Mack merged patch set 4 10/30/26, 10:51