Review 14.3 Merged

97245[BUGFIX] Use resolved table for record list docheader

Oli Bartsch CR +2 V +2 Normal +49 −4 updated 10/30/26, 22:08

Commit message

The Records module passed the raw "table" request argument to the
docheader buttons. Only DatabaseRecordList::start() checks the name
and maps the "pages_translated" name of the page translations view
to "pages". Expanding the "Page Translation" table therefore threw
an UndefinedSchemaException in the new record button. Any unknown
table name in the URL crashed in the same way. The export button
also got "pages_translated" as its table name.

The new record and export buttons now use the table resolved by
DatabaseRecordList. They are skipped if no valid table is set. The
export button is also hidden in the page translations view, as the
download button already is: the list export of EXT:impexp selects
records by pid and cannot select the translations of a page. The
view is detected through a new internal getter of
DatabaseRecordList, so the pseudo table name stays in that class.
The raw argument is still used to build module URLs, so the
expanded view is kept.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 10/30/26, 21:57

  2. core-ci voted on patch set 1 V +1 10/30/26, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112920

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/30/26, 22:08

  4. Oli Bartsch merged patch set 2 10/30/26, 22:08