Review main Merged

97248[TASK] Use CacheFlusher instead of DataHandler->clear_cacheCmd()

Benni Mack CR +2 V +2 Hard +226 −26 updated 11/04/26, 10:08

Commit message

The admin panel, the form editor, the indexed_search administration
and the styleguide generator flushed page caches via CacheManager
directly or started a DataHandler only to flush caches. They now use
CacheFlusher, so the cache flushing events are dispatched for them
as well.

SimpleDataHandlerController flushes its "cacheCmd" via CacheFlusher
with the permissions of the backend user, and logs it as before.

DataHandler->clear_cacheCmd() is deprecated in favor of
CacheFlusher->flush() with CacheFlushDemand::forCommand().

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Daniel Windloff +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Daniel Windloff +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 910

  1. Benni Mack uploaded patch set 1 10/31/26, 08:42

  2. core-ci voted on patch set 1 V +1 10/31/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112943

  3. Daniel Windloff voted on patch set 1 CR +1 11/03/26, 08:19

  4. Daniel Windloff voted on patch set 1 V +1 11/03/26, 09:01

  5. Markus Klein commented on patch set 1 11/03/26, 09:21

    FormEditorController.php:647

    shouldn't we keep the array_unique here?
  6. Benni Mack commented on patch set 1 11/03/26, 09:49

    FormEditorController.php:647 Reply

    it's now done in the flusher (array_unique) and is only executing one command instead of multiple times with the foreach now.
  7. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/03/26, 10:15

  8. Oliver Klee voted on patch set 1 CR +1 V +1 11/03/26, 11:15

  9. Garvin Hicking commented on patch set 1 CR +2 V +2 11/04/26, 10:08

    FormEditorController.php:647 Reply

    Done
  10. Garvin Hicking merged patch set 2 11/04/26, 10:08