Review main Merged

97253[TASK] Extract page ancestry CTE into PageAncestryRepository

Benni Mack CR +2 V +2 Expert +638 −559 updated 11/01/26, 10:12

Commit message

RootlineUtility resolves the rootline of a page, including
workspace overlays, with one recursive common table expression.
The query is however bound to RootlineUtility, which also deals
with mount points, language overlays and relations for the
frontend.

The recursive CTE is now provided by the internal service
PageAncestryRepository. findAncestry() yields the workspace
resolved page records from the given page up to the root level,
one by one, so consumers stopping early - like RootlineUtility
on a mounted page - behave as before.

This is a preparation for resolving the ancestry of a page in
the backend with one query instead of one query per level as
done by BackendUtility::BEgetRootLine().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 10/31/26, 10:58

  2. core-ci voted on patch set 1 V +1 10/31/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112951

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 11/01/26, 09:02

  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/01/26, 09:38

  5. Benni Mack voted on patch set 1 CR +2 V +2 11/01/26, 10:12

  6. Benni Mack merged patch set 2 11/01/26, 10:12