Review main Merged

97259[BUGFIX] Keep module menu line after collapsing

Georg Ringer CR +2 V +2 Easy +4 −4 updated 11/01/26, 19:37

Commit message

In Firefox, the vertical line next to a nested module group disappeared
after the group had been collapsed and opened again, while its
indentation stayed.

The line is a pseudo-element, so its unnamed container query resolved
against the group itself instead of the menu that decides about the
indentation. Firefox did not bring the line back once the collapse
transition had ended.

A named container on the menu now makes the line and the indentation
depend on the same width. The Playwright suite runs Chromium only,
which is not affected, so the change comes without an automated test.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Georg Ringer uploaded patch set 1 10/31/26, 13:58

  2. Georg Ringer commented on patch set 1 10/31/26, 14:01

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/31/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112958

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/01/26, 17:06

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 11/01/26, 19:37

  6. Oli Bartsch merged patch set 2 11/01/26, 19:37