Review main Merged

97264[BUGFIX] Only resolve version ids for workspace-aware MM relations

Benni Mack CR +2 V +2 Normal +147 −1 updated 11/09/26, 21:19

Commit message

The migration of RelationHandler to the Schema API inverted the
check in convertItemArray(): workspace-aware tables were skipped and
tables without versioning were run through the version overlay
resolution instead.

For tables without versioning, PlainDataResolver returns the ids
as a plain list. The lookup by uid then used the uid as a list
index, so several items could end up with the same id. Saving an
MM select in a workspace then failed on a duplicate primary key.

The check is restored, so only workspace-aware tables get their
live ids converted to version ids.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1015

  1. Benni Mack uploaded patch set 1 10/31/26, 15:54

  2. core-ci voted on patch set 1 V -1 10/31/26, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112967

  3. core-ci commented on patch set 1 10/31/26, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112967

  4. Benni Mack rebased onto patch set 2 V -1 11/09/26, 17:29

  5. core-ci voted on patch set 2 V -1 11/09/26, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113745

  6. Benni Mack rebased onto patch set 3 V -1 11/09/26, 18:37

  7. core-ci voted on patch set 3 V +1 11/09/26, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113759

  8. Benjamin Franzke voted on patch set 3 CR +1 11/09/26, 19:01

  9. Oli Bartsch uploaded patch set 4 CR +1 V +1 11/09/26, 19:43

  10. Oli Bartsch commented on patch set 4 CR +1 V +1 11/09/26, 19:45

    I've added an additonal DH workspace scenario. It modifies a category in workspace, relates content to it, and checks that the MM row stores the category's version uid, and not the live uid.
  11. core-ci voted on patch set 4 V +1 11/09/26, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113771

  12. Oliver Klee voted on patch set 4 V +1 11/09/26, 20:28

  13. Wouter Wolters voted on patch set 4 CR +1 V +1 11/09/26, 20:56

  14. Benni Mack voted on patch set 4 CR +2 V +2 11/09/26, 21:19

  15. Benni Mack merged patch set 5 11/09/26, 21:19