Review main Merged

97265[BUGFIX] Skip group simulation for group members

Benni Mack CR +2 V +2 Normal +109 −0 updated 11/19/26, 09:37

Commit message

A backend preview link of an access restricted page carries
ADMCMD_simUser, and while a backend user is logged in, the parameter is
kept on every link generated in the frontend.

If a frontend user is logged in as well and is already member of the
simulated group, the simulation still replaced the user ID with a fake
one, overwrote the usergroup field and flagged the request as preview.
The visitor then saw a preview with a fake user instead of the page as
the real frontend user.

The simulation is now skipped if all simulated groups are already part
of the current frontend user aspect.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1014

  1. Benni Mack uploaded patch set 1 10/31/26, 15:54

  2. core-ci voted on patch set 1 V +1 10/31/26, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112968

  3. Benni Mack uploaded patch set 2 V +1 11/18/26, 22:28

  4. core-ci voted on patch set 2 V +1 11/18/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114942

  5. Benni Mack marked it ready for review 11/19/26, 06:35

  6. Benni Mack rebased onto patch set 3 V +1 11/19/26, 08:27

  7. core-ci voted on patch set 3 V -1 11/19/26, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114973

  8. Benni Mack uploaded patch set 4 V -1 11/19/26, 09:04

  9. core-ci voted on patch set 4 V +1 11/19/26, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114981

  10. Josua Vogel voted on patch set 4 CR +1 V +1 11/19/26, 09:11

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/19/26, 09:18

  12. Georg Ringer voted on patch set 4 CR +1 V +1 11/19/26, 09:36

  13. Benni Mack voted on patch set 4 CR +2 V +2 11/19/26, 09:37

  14. Benni Mack merged patch set 5 11/19/26, 09:37