Review main Merged

97268[BUGFIX] Let users update extensions marked as outdated

Benni Mack CR +2 V +2 Normal +75 −4 updated 11/01/26, 10:43

Commit message

The Extension Manager's "show all versions" list excluded any
version with a negative review state, hiding both "insecure" (-1)
and "outdated" (-2) versions alike.

Outdated is only a recommendation: TER still serves that version's
download. Hiding it meant a user following a security bulletin that
explicitly said "update to this version" could not find that version
in the Extension Manager at all.

Two places made the same mistake:

- ExtensionRepository::findByExtensionKeyOrderedByVersion(), the
  locally imported list used as a fallback when TER cannot be
  reached.
- TerExtensionCatalogue, which reads the same data live from TER and
  is now the primary path (#109582): findByExtensionKeyOrderedByVersion(),
  findOneByCurrentVersionByExtensionKey() and the toExtensions() helper
  shared by every listing method all excluded "outdated" as well.

Both now exclude only "insecure", matching the fix the original
report suggested six years ago.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 911

  1. Benni Mack uploaded patch set 1 10/31/26, 18:55

  2. Benni Mack marked it ready for review 10/31/26, 18:57

  3. core-ci voted on patch set 1 V +1 10/31/26, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112972

  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/01/26, 07:04

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 11/01/26, 08:54

  6. Benni Mack updated the commit message in patch set 2 CR +1 V +1 11/01/26, 10:19

  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/01/26, 10:20

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 11/01/26, 10:20

  9. core-ci voted on patch set 2 V +1 11/01/26, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113000

  10. Benni Mack voted on patch set 2 CR +2 V +2 11/01/26, 10:43

  11. Benni Mack merged patch set 3 11/01/26, 10:43