Review main Merged

97269[TASK] Flush caches of Extbase persistence via CacheFlusher

Benni Mack CR +2 V +2 Hard +350 −312 updated 11/06/26, 21:23

Commit message

Extbase collected persisted records in its internal CacheService and
flushed their page caches only when the bootstrap had rendered a
plugin or module. Records persisted in console commands or scheduler
tasks never flushed any cache.

The persistence backend now flushes the caches of persisted records
via CacheFlusher once per persistAll(). Page TSconfig is respected
like for records saved in the backend, cache commands never flush
the "pages" group or all caches, and the cache flushing events are
dispatched. CacheService is removed.

CacheFlusher additionally flushes the cache tag "<table>_pid_<pid>",
which Extbase repositories add with automatic frontend cache tagging,
so records saved in the backend evict cached lists of their storage
page as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1316

  1. Benni Mack uploaded patch set 1 10/31/26, 20:15

  2. core-ci voted on patch set 1 V +1 10/31/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112976

  3. Benni Mack uploaded patch set 2 V +1 10/31/26, 20:30

  4. Benni Mack marked it ready for review 10/31/26, 20:30

  5. Benni Mack wrote 10/31/26, 20:30

    Topic set to extbase
  6. core-ci voted on patch set 2 V +1 10/31/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112977

  7. Markus Klein commented on patch set 2 11/03/26, 09:11

    Backend.php:781

    What if the pid changed for the record? We need to flush old and new location then, right?
  8. Oliver Klee voted on patch set 2 CR +1 V +1 11/03/26, 11:16

  9. Benni Mack uploaded patch set 3 CR +1 V +1 11/06/26, 12:54

  10. core-ci voted on patch set 3 V +1 11/06/26, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113509

  11. Benni Mack commented on patch set 3 11/06/26, 13:19

    Backend.php:781 Reply

    good point. fixed!
  12. Oliver Klee voted on patch set 3 CR +1 V +1 11/06/26, 15:01

  13. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/06/26, 15:08

  14. Garvin Hicking commented on patch set 3 CR +1 V +1 11/06/26, 20:07

    nice!
  15. Benni Mack voted on patch set 3 CR +2 V +2 11/06/26, 21:23

  16. Benni Mack merged patch set 4 11/06/26, 21:23