Review main Merged

97272[DOCS] Explain matching of Respect GET Parameters

Georg Ringer CR +2 V +2 Normal +52 −2 updated 11/06/26, 20:16

Commit message

The redirects manual claimed that the option only decides whether query
parameters are matched. Without a regular expression it has to fit the
source path, otherwise the redirect never matches, and with a regular
expression a disabled option matches against the path and the query
string as well.

The field stays necessary for regular expressions, so the manual now
explains both cases and shows the resulting matches in a table.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Georg Ringer uploaded patch set 1 11/01/26, 09:13

  2. Georg Ringer commented on patch set 1 11/01/26, 09:13

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 11/01/26, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112997

  4. core-ci commented on patch set 1 11/01/26, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112997

  5. Georg Ringer rebased onto patch set 2 V -1 11/01/26, 10:28

  6. core-ci voted on patch set 2 V +1 11/01/26, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113004

  7. Benni Mack voted on patch set 2 CR +1 V +1 11/02/26, 05:52

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 00:52

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 11/06/26, 18:33

  10. Garvin Hicking merged patch set 3 11/06/26, 20:16