Review main Merged

97273[TASK] Make DataHandlerCacheFlushTest order-safe

Georg Ringer CR +2 V +2 Easy +7 −1 updated 11/01/26, 10:23

Commit message

The clear cache queue of DataHandler is static and survives between
test classes. Code calling methods like deleteAction() directly leaves
entries behind, which the first DataHandler run of the test then
reported as well. The test now drains the queue in setUp().

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Georg Ringer uploaded patch set 1 11/01/26, 10:03

  2. Georg Ringer commented on patch set 1 11/01/26, 10:03

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/01/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112998

  4. Benni Mack commented on patch set 1 CR +2 V +2 11/01/26, 10:22

    The leftovers point to a production issue: recycler DeletedRecords::deleteData(), DeletedRecordsCommand and WorkspaceVersionRecordsCommand call deleteAction() directly, so their queue entries are never flushed and stay in the static $recordsToClearCacheFor until the next DataHandler run in that process (in worker mode: the next request, under another user). I'd like to fix that separately by binding the queue to the outermost instance; this test fix is fine as a stopgap until then.
  5. Benni Mack merged patch set 2 11/01/26, 10:23