Review main Merged

97283[TASK] Avoid PHP 8.6 deprecation in callUserFunction()

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 11/02/26, 20:11

Commit message

PHP 8.6 deprecates calling is_a() with a string when allow_string is
false. String callbacks in GeneralUtility::callUserFunction() therefore
trigger a deprecation before they are resolved.

Use instanceof to detect closures without changing callback behavior.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Wouter Wolters uploaded patch set 1 11/01/26, 17:34

  2. Wouter Wolters updated the commit message in patch set 2 11/01/26, 17:35

  3. core-ci voted on patch set 1 V +1 11/01/26, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113031

  4. core-ci voted on patch set 2 V +1 11/01/26, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113032

  5. Wouter Wolters updated the commit message in patch set 3 V +1 11/01/26, 18:28

  6. core-ci voted on patch set 3 V +1 11/01/26, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113037

  7. Oliver Klee voted on patch set 3 CR +1 V +1 11/01/26, 21:29

  8. Georg Ringer voted on patch set 3 CR +2 V +2 11/02/26, 19:42

  9. Georg Ringer merged patch set 4 11/02/26, 20:11