Review main Merged

97284[TASK] Complete Install Tool session handlers for PHP 8.6

Wouter Wolters CR +2 V +2 Normal +172 −0 updated 11/04/26, 08:35

Commit message

PHP 8.6 reports warnings and deprecations for session handlers without
create_sid() and validateId(). Implement both methods for file and Redis
storage, generating random IDs and accepting only existing sessions.
Validation must not read or create session data.

Cover empty stored sessions, unknown and destroyed IDs, and strict-mode
session creation, resumption and regeneration with functional tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 58

  1. Wouter Wolters uploaded patch set 1 11/01/26, 18:22

  2. Wouter Wolters updated the commit message in patch set 2 11/01/26, 18:23

  3. Wouter Wolters updated the commit message in patch set 3 11/01/26, 18:27

  4. core-ci voted on patch set 1 V +1 11/01/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113034

  5. core-ci voted on patch set 2 V +1 11/01/26, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113035

  6. core-ci voted on patch set 3 V +1 11/01/26, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113036

  7. Benni Mack voted on patch set 3 CR +2 V +2 11/04/26, 08:35

  8. Benni Mack merged patch set 4 11/04/26, 08:35