Review main Merged

97285[TASK] Avoid empty unserialize input on PHP 8.6

Wouter Wolters CR +2 V +2 Normal +110 −4 updated 11/05/26, 09:55

Commit message

PHP 8.6 warns when unserialize() receives an empty string. Guard empty
input in processed-file configuration, user sessions, stored database
queries and extension dependencies.

Preserve existing casts and empty results, including the legacy [false]
processed-file configuration, and retain allowed_classes restrictions.
Nonempty input continues through the existing deserialization paths.

Cover absent, null and empty fields, existing serialized data and
saved-query persistence with regression tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 45

  1. Wouter Wolters uploaded patch set 1 11/01/26, 18:39

  2. core-ci voted on patch set 1 V +1 11/01/26, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113038

  3. Oliver Klee voted on patch set 1 CR +1 V +1 11/01/26, 21:29

  4. Benni Mack voted on patch set 1 CR +2 V +2 11/05/26, 09:55

  5. Benni Mack merged patch set 2 11/05/26, 09:55