Review main Merged

97292[BUGFIX] Verify step-up authentication before copying

Oli Bartsch CR +2 V +2 Hard +249 −34 updated 11/06/26, 09:19

Commit message

When a record with fields requiring step-up authentication, such as a
backend user, was copied, DataHandler::copyRecord() copied inline and
file children (e.g. the avatar file reference) to the database first.
Only afterwards the copied record itself was processed through the
datamap, where DataHandlerAuthenticationContext threw the
VerificationRequiredException. The copied references were never
remapped to the new record and remained attached to the source record,
which then had duplicated file references, regardless of whether the
step-up dialog was cancelled or confirmed.

DataHandlerAuthenticationContext now additionally implements
processCmdmap_preProcess() and verifies required grants for "copy"
commands before the copied record and its children are written.
Non-repeatable grants are still consumed by the datamap hook only.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Oli Bartsch uploaded patch set 1 11/01/26, 22:19

  2. core-ci voted on patch set 1 V +1 11/01/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113049

  3. Oli Bartsch uploaded patch set 2 V +1 11/01/26, 22:36

  4. core-ci voted on patch set 2 V +1 11/01/26, 22:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113051

  5. Oli Bartsch uploaded patch set 3 V +1 11/01/26, 23:02

  6. core-ci voted on patch set 3 V +1 11/01/26, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113052

  7. Benni Mack voted on patch set 3 CR +1 V +1 11/02/26, 05:56

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/06/26, 00:31

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 11/06/26, 09:19

  10. Oli Bartsch merged patch set 4 11/06/26, 09:19