Review main Merged

97295[BUGFIX] Check access before localizing child records

Oli Bartsch CR +2 V +2 Normal +213 −0 updated 11/12/26, 18:31

Commit message

DataHandler::localizeRecord() localizes child records such as file
references while it processes the fields of the record. The localized
record itself was only checked later, when it went through the datamap.
When only that record was rejected, for example because the editor is
not allowed to use its CType or may not modify its table, the localized
children stayed behind, still attached to the default language record.

The record to be localized is now checked for table modify access,
insert permission on the destination page and record edit access
before any child record is written.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 811

  1. Oli Bartsch uploaded patch set 1 11/02/26, 08:47

  2. core-ci voted on patch set 1 V +1 11/02/26, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113073

  3. Oli Bartsch rebased onto patch set 2 V +1 11/11/26, 09:58

  4. core-ci voted on patch set 2 V +1 11/11/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114037

  5. Josua Vogel commented on patch set 2 11/12/26, 08:32

    DataHandler.php:4975

    Would it be necessary to check, if the record may be inserted on the destination page?
  6. Oli Bartsch uploaded patch set 3 V +1 11/12/26, 16:34

  7. Oli Bartsch commented on patch set 3 11/12/26, 16:35

    DataHandler.php:4975 Reply

    Good point, thanks.
  8. core-ci voted on patch set 3 V +1 11/12/26, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114199

  9. Josua Vogel voted on patch set 3 CR +1 V +1 11/12/26, 17:21

  10. Benni Mack voted on patch set 3 CR +2 V +2 11/12/26, 18:30

  11. Benni Mack merged patch set 4 11/12/26, 18:31