Review main Merged

97308[BUGFIX] Respect default target in RTE link browser

Benjamin Kott CR +2 V +2 Normal +116 −21 updated 11/20/26, 11:47

Commit message

The switch of the target field to the combobox rendered the current
link's target only, so a target configured in
buttons.link[.<type>].properties.target.default was computed but no
longer applied to new links. The field shows the configured default for
new links again.

Defaults apply to new links only, the RTE's own and those from
TCEMAIN.linkHandler alike. The CKEditor passes only the attributes a
link carries, so the per-attribute check of the TCEMAIN defaults
prefilled an existing link without a target or class. Editing a link
now never adds a default unasked or brings back a value an editor
removed.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benjamin Kott uploaded patch set 1 11/02/26, 19:58

  2. core-ci voted on patch set 1 V +1 11/02/26, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113106

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/20/26, 11:19

  4. Garvin Hicking merged patch set 2 11/20/26, 11:47