Review 14.3 Merged

97311[BUGFIX] Update reference index of redirects created for slug changes

Benni Mack CR +2 V +2 Easy +31 −4 updated 11/06/26, 09:52

Commit message

When a page slug is changed, the redirects created for it and the
updated sub page slugs are written in separate DataHandler runs, which
got their own reference index updater. It was never flushed, since
these runs are not the outermost DataHandler, so the created redirects
were missing in the reference index. SlugService now uses the
reference index updater of the DataHandler changing the slug, which
updates the index when it has finished.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 11/03/26, 07:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/03/26, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113125

  3. Benni Mack rebased onto patch set 2 V -1 11/03/26, 09:48

  4. core-ci voted on patch set 2 V +1 11/03/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113135

  5. Oliver Klee voted on patch set 2 V +1 11/03/26, 11:15

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/06/26, 09:52

  7. Benni Mack merged patch set 3 11/06/26, 09:52