97312[BUGFIX] Keep page tree refresh flag of nested DataHandler runs
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Daniel Windloff +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Daniel Windloff +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −4
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −2
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+1 −2
- typo3/sysext/backend/Tests/Functional/Controller/RecordListControllerTest.php+22 −0
- typo3/sysext/backend/Tests/Functional/Controller/SimpleDataHandlerControllerTest.php+41 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/ActionTest.php+3 −0
Review log 1518
-
Benni Mack uploaded patch set 1 11/03/26, 08:05
-
core-ci voted on patch set 1 V +1 11/03/26, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113128
-
Daniel Windloff commented on patch set 1 11/03/26, 08:26
`EditDocumentController` evaluates `$dataHandler->pagetreeNeedsRefresh && (isset($dataMap['pages']) || $beUser->workspace !== 0 && !empty($dataMap))` to check if the page tree refresh is needed. As the datamap is also in the subinstance, transferring the flag might be enough. Besides that, I think `pagetreeNeedsRefresh` should not be part of DataHandler. Evaluating the NEW placeholder and history may remove the flag entirely, as the logic should be in the controller and not in the persistence class. -
Oliver Klee voted on patch set 1 V +1 11/03/26, 11:17
-
Benni Mack commented on patch set 1 11/04/26, 05:59
Reply
in general I agree, right now, I'm mainly fixing a leftover problem so we can get rid of this option properly later-on... -
Benni Mack uploaded patch set 2
V +111/04/26, 07:24 -
Benni Mack commented on patch set 2 11/04/26, 07:24
Reply
I did clean up the places where I think can also be simplified now -
core-ci voted on patch set 2 V +1 11/04/26, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113253
-
Georg Ringer voted on patch set 2 CR +1 V +1 11/04/26, 09:16
-
Daniel Windloff commented on patch set 2 11/05/26, 19:16
The `SimpleDataHandlerController` does not use the flag at all. For instance, when editing a live record within a workspace (which triggers the auto-creation of that workspace) the page tree is reloaded via `EditDocumentController`. Conversely, when a record is copied in a workspace, the page tree is not reloaded, even though the page record is marked after a reload of the page tree. Furthermore, the `DataMapProcessor` does not pass the state of the page tree refresh back to the parent `DataHandler`. However, the use cases for this would likely be quite limited. -
Benni Mack uploaded patch set 3
CR +1V +111/07/26, 21:49 -
Benni Mack commented on patch set 3 11/07/26, 21:49
Reply
Thanks - you are right: SimpleDataHandlerController now only evaluates the flag as well. That also fixes two cases: records created in a workspace via tce_db now refresh the page tree, and changing a page field that is not shown in the tree no longer does. -
core-ci voted on patch set 3 V +1 11/07/26, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113577
-
Daniel Windloff voted on patch set 3 CR +1 V +1 11/07/26, 22:01
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/08/26, 19:44
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/09/26, 08:26
-
Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 08:32
-
Benni Mack merged patch set 4 11/09/26, 08:32