Review 13.4 Merged

97314[BUGFIX] Keep flushing caches when a queued record is invalid

Andreas Kienast CR +2 V +2 Normal +108 −1 updated 11/03/26, 10:56

Commit message

DataHandler::processClearCacheQueue() returned as soon as one queued
record had a uid <= 0 or belonged to a table without TCA. The page
caches of all other records of the run were not flushed, and the
static queue was not reset, so the invalid entry also prevented the
cache flush of every later DataHandler run in the same process.

Invalid entries are now skipped.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Andreas Kienast commented on patch set 1 11/03/26, 10:46

    Cherry Picked from branch 14.3.
  2. Andreas Kienast updated the commit message in patch set 2 11/03/26, 10:46

  3. Andreas Kienast commented on patch set 2 11/03/26, 10:47

    After having a chat with Benni, we agreed to backport this to v13 as well.
  4. core-ci voted on patch set 1 V +1 11/03/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113141

  5. core-ci voted on patch set 2 V +1 11/03/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113142

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 11/03/26, 10:56

  7. Andreas Kienast merged patch set 3 11/03/26, 10:56