Review main Merged

97315[TASK] Use page ancestry for TSconfig, page tree and module rootlines

Benni Mack CR +2 V +2 Normal +87 −57 updated 11/09/26, 09:42

Commit message

Further callers of BackendUtility::BEgetRootLine() now use the
PageAncestryResolver, which resolves the ancestry of a page with
one query instead of one query per page level.

Callers which already requested the workspace overlay:

* PageTsConfigIncludesController, PageTsConfigActiveController
* TemplateRecordsOverviewController
* TreeController (mount point path)
* PreviewController (draft version URL)
* PageTreeRepository (filtering pages on mount points)
* BackendUserAuthentication::initializeDbMountpointsInWorkspace(),
  now using the workspace of the user object instead of the global
  backend user
* BackendLayoutView, whose test now stubs the resolver instead of
  seeding the runtime cache of BEgetRootLine()

The following callers did not apply the workspace overlay before
and now resolve the ancestry in the workspace of the backend user,
so pages moved in a workspace are taken into account:

* SiteConfigurationController
* AbstractTemplateModuleController
* PageInformationController, TranslationStatusController

PageTsConfigRecordsOverviewController lists live pages only and
keeps resolving the live ancestry.

TreeController builds the mount point path from Page objects, and
the workspace mount check only uses the page ids of the ancestry.
PageAncestry::getPagesFromRootLevel() returns the pages ordered
from the root level.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1418

  1. Benni Mack uploaded patch set 1 11/03/26, 11:17

  2. core-ci voted on patch set 1 V +1 11/03/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113145

  3. Stefan Bürk voted on patch set 1 CR +1 11/05/26, 16:28

  4. Simon Schaufelberger commented on patch set 1 11/05/26, 16:39

    TreeController.php:120

    even though this is internal, can you use protected to allow xclasses to use this class just in case they need to?
  5. Benni Mack commented on patch set 2 CR +1 V +1 11/05/26, 16:50

    Published edit on patch set 1.
  6. Benni Mack commented on patch set 2 11/05/26, 16:50

    TreeController.php:120 Reply

    Done
  7. Simon Schaufelberger voted on patch set 2 CR +1 11/05/26, 16:51

  8. core-ci voted on patch set 2 V +1 11/05/26, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113417

  9. Stefan Bürk voted on patch set 2 CR +1 11/05/26, 18:05

  10. Georg Ringer voted on patch set 2 CR +1 V +1 11/06/26, 05:50

  11. Benni Mack uploaded patch set 3 CR +1 V +1 11/06/26, 06:05

  12. core-ci voted on patch set 3 V -1 11/06/26, 06:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113449

  13. Benni Mack rebased onto patch set 4 V -1 11/06/26, 12:51

  14. core-ci voted on patch set 4 V +1 11/06/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113508

  15. Georg Ringer voted on patch set 4 CR +1 V +1 11/07/26, 06:30

  16. Jochen Roth voted on patch set 4 CR +1 V +1 11/09/26, 09:36

  17. Benni Mack voted on patch set 4 CR +2 V +2 11/09/26, 09:42

  18. Benni Mack merged patch set 5 11/09/26, 09:42