Review main Merged

97316[TASK] Deprecate LanguageAspect::OVERLAYS_ON

Benni Mack CR +2 V +2 Hard +353 −282 updated 11/04/26, 05:29

Commit message

The overlay type "on" is never created from a site configuration:
fallbackType "strict" maps to OVERLAYS_ON_WITH_FLOATING, "fallback"
to OVERLAYS_MIXED and "free" to OVERLAYS_OFF. PageRepository already
treats "on" and "includeFloating" the same way, the only difference
is that CONTENT and Extbase skip records without a default language
record.

The overlay type is deprecated in favor of
OVERLAYS_ON_WITH_FLOATING to reduce the number of overlay modes.
Creating a LanguageAspect with "on" triggers a deprecation, the
behavior is kept until the removal in TYPO3 v16.

Tests use OVERLAYS_ON_WITH_FLOATING now, duplicate data sets for
both overlay types are removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 67

  1. Benni Mack uploaded patch set 1 11/03/26, 11:19

  2. core-ci voted on patch set 1 V +1 11/03/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113146

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/03/26, 11:39

  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/03/26, 11:48

  5. Oliver Klee voted on patch set 1 CR +1 V +1 11/03/26, 12:49

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/04/26, 05:29

  7. Benni Mack merged patch set 2 11/04/26, 05:29