Review 14.3 Merged

97318[TASK] Harden output escaping of QR code form element

Georg Ringer CR +2 V +2 Easy +1 −1 updated 11/03/26, 12:08

Commit message

The QR code form element of EXT:redirects rendered the
"content" attribute of the <typo3-qrcode> component by
concatenating "source_host" and "source_path" without
escaping.

"source_path" is generated automatically for QR codes and
is not part of the form, but DataHandler accepts it for
users with write access to sys_redirect.

This is not a security vulnerability: the backend Content
Security Policy is always enforced and does not allow
inline scripts or event handler attributes, so injected
markup cannot execute JavaScript.

As a hardening measure, the value is now escaped with
htmlspecialchars(), like it is already done in
ShortUrlElement.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 11/03/26, 11:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/03/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113150

  3. Georg Ringer voted on patch set 1 CR +2 V +2 11/03/26, 12:08

  4. Georg Ringer merged patch set 2 11/03/26, 12:08