97319[BUGFIX] Resolve pages new in a workspace along their workspace ancestry
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Domain/PageAncestryResolver.php+32 −0
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/WorkspacePagesInWebMount.csvnew+23 −0
- typo3/sysext/core/Tests/Functional/Authentication/WorkspacePagesInWebMountTest.phpnew+70 −0
- typo3/sysext/core/Tests/Functional/Domain/Fixtures/PageAncestry.csv+15 −15
- typo3/sysext/core/Tests/Functional/Domain/PageAncestryResolverTest.php+31 −0
Review log 1114
-
Benni Mack uploaded patch set 1 11/03/26, 11:46
-
core-ci voted on patch set 1 V +1 11/03/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113151
-
Oli Bartsch commented on patch set 1 11/06/26, 13:03
-
Benni Mack commented on patch set 1 11/06/26, 13:21
BackendUserAuthentication.php:347Replythere are various changes in this pipeline already (and more about the PageAncestry) see https://review.typo3.org/c/Packages/TYPO3.CMS/+/97323 -
Benni Mack uploaded patch set 2
V +111/06/26, 21:39 -
Benni Mack commented on patch set 2 11/06/26, 21:40
BackendUserAuthentication.php:347ReplyI double-checkc the other places... I moved the handling into PageAncestryResolver::resolve(): a page new in another workspace is resolved along the ancestry of its own workspace if the requested one has none, so getPagesTSconfig(), SlugHelper, FormEngine and isInWebMount() agree. The special case in isInWebMount() is gone. -
core-ci voted on patch set 2 V +1 11/06/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113538
-
Benni Mack uploaded patch set 3
V +111/06/26, 21:55 -
core-ci voted on patch set 3 V +1 11/06/26, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113542
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/07/26, 10:27
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/07/26, 12:11
-
Oli Bartsch voted on patch set 3 CR +1 V +1 11/07/26, 14:40
-
Benni Mack voted on patch set 3 CR +2 V +2 11/07/26, 21:43
-
Benni Mack merged patch set 4 11/07/26, 21:43
BackendUserAuthentication.php:347