Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

97323[TASK] Check page access along the cached page ancestry

Benni Mack CR 0 V 0 Normal +166 −1 updated 11/18/26, 19:31

Commit message

Most backend modules call BackendUtility::readPageAccess() with the
show permission clause of the user. As a clause was given,
isInWebMount() walked the page tree with it, one query per page
level, and getRecordPath() walked it a second time, as the runtime
cache of BEgetRootLine() differs in the prefix of the clause.

isInWebMount() now treats the show permission clause of the user
like no clause and checks the page along its ancestry, resolved with
one query and kept for the request. readPageAccess() takes the record
path from the same ancestry, up to the first page not shown to the
user. Other clauses, listeners of the ModifyPagePermissionClauseEvent
and the deprecated getPagePermsClause hook keep the walk with the
clause.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 12
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/97323/12 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/97323/12 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 5

  1. main 96852[TASK] Add check whether a user may read a field Based on this change Merge conflict Oli Bartsch CR 0 V 0 Hard +320 −3
  2. main 96580[TASK] Add check whether a user may read a record Based on this change Merge conflict Oli Bartsch CR 0 V 0 Expert +1773 −28
  3. 97323 [TASK] Check page access along the cached page ancestry This change

  4. main 97322[FEATURE] Decide page permissions with a security voter This change is based on it Benni Mack CR 0 V 0 Expert +1489 −151
  5. main 95784[FEATURE] Decide table, field and language access with voters This change is based on it Thomas Maroschik CR +1 V +1 unified-identity-security-kernel Expert +1215 −11

Issues 3

Files 4

Review log 1222

  1. Benni Mack uploaded patch set 1 11/03/26, 14:43

  2. core-ci voted on patch set 1 V -1 11/03/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113169

  3. Benni Mack uploaded patch set 2 V -1 11/09/26, 10:12

  4. core-ci voted on patch set 2 V -1 11/09/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113645

  5. Benni Mack rebased onto patch set 3 V -1 11/10/26, 20:26

  6. core-ci voted on patch set 3 V +1 11/10/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113952

  7. Benni Mack rebased onto patch set 4 V +1 11/13/26, 14:31

  8. Benni Mack rebased onto patch set 5 11/13/26, 19:02

  9. Benni Mack rebased onto patch set 6 11/13/26, 20:59

  10. core-ci voted on patch set 6 V +1 11/13/26, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114402

  11. Benni Mack rebased onto patch set 7 V +1 11/17/26, 15:48

  12. core-ci voted on patch set 7 V +1 11/17/26, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114760

  13. Benni Mack rebased onto patch set 8 V +1 11/17/26, 18:50

  14. core-ci voted on patch set 8 V -1 11/17/26, 19:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114783

  15. Benni Mack rebased onto patch set 9 V -1 11/18/26, 08:04

  16. core-ci voted on patch set 9 V +1 11/18/26, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114830

  17. Benni Mack rebased onto patch set 10 V +1 11/18/26, 10:35

  18. core-ci voted on patch set 10 V +1 11/18/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114850

  19. Benni Mack rebased onto patch set 11 V +1 11/18/26, 19:05

  20. Benni Mack rebased onto patch set 12 11/18/26, 19:16

  21. core-ci voted on patch set 11 V +1 11/18/26, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114908

  22. core-ci voted on patch set 12 V +1 11/18/26, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114916