Review 13.4 Merged

97335[TASK] Complete Install Tool session handlers for PHP 8.6

Benni Mack CR +2 V +2 Easy +10 −0 updated 11/05/26, 08:36

Commit message

PHP 8.6 reports warnings and deprecations for session handlers without
create_sid() and validateId(). Implement both methods for file and Redis
storage, generating random IDs and accepting only existing sessions.
Validation must not read or create session data.

Cover empty stored sessions, unknown and destroyed IDs, and strict-mode
session creation, resumption and regeneration with functional tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 711

  1. Benni Mack commented on patch set 1 11/04/26, 08:35

    Cherry Picked from branch 14.3. The following files contain Git conflicts: * typo3/sysext/install/Classes/Service/Session/RedisSessionHandler.php
  2. Benni Mack commented on patch set 2 11/04/26, 08:35

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 11/04/26, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113256

  4. core-ci voted on patch set 2 V -1 11/04/26, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113257

  5. Benni Mack commented on patch set 3 V -1 11/04/26, 20:17

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 11/04/26, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113316

  7. Benni Mack commented on patch set 4 V -1 11/04/26, 20:32

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 11/04/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113319

  9. Benni Mack marked it ready for review 11/05/26, 08:36

  10. Benni Mack voted on patch set 4 CR +2 V +2 11/05/26, 08:36

  11. Benni Mack merged patch set 5 11/05/26, 08:36