Review main Merged

97342[TASK] Provide more context in IsReferenceConsideredForDependencyEvent

Simon Praetorius CR +2 V +2 Normal +201 −12 updated 11/09/26, 12:49

Commit message

Introduced tests in #111337 revealed a few shortcomings of the current
dependency resolving during workspace publishing. To be able to address
some of these, more context information is necessary in the
`IsReferenceConsideredForDependencyEvent`.

This patch extends the existing event with 4 properties and getters:

* `getFlexPointer()` allows event listeners to gain more information
  about references from flexform fields
* `getSoftReferenceKey()` and `getSoftReferenceId()` give more context
  to soft references (e. g. links in RTEs)
* `getDirection()` lets event listeners differentiate between parents
  and children resolving by the `DependencyResolver`

Note that this patch doesn't further change the default resolving
strategy in the Core. With this additional context in place, this can
be accomplished in follow-up patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 811

  1. Simon Praetorius uploaded patch set 1 11/04/26, 16:07

  2. core-ci voted on patch set 1 V +1 11/04/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113297

  3. Simon Praetorius uploaded patch set 2 V +1 11/04/26, 17:11

  4. Simon Praetorius marked it ready for review 11/04/26, 17:11

  5. core-ci voted on patch set 2 V +1 11/04/26, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113305

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 00:57

  7. Simon Praetorius updated the commit message in patch set 3 CR +1 V +1 11/06/26, 12:23

  8. core-ci voted on patch set 3 V +1 11/06/26, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113506

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 11/06/26, 20:00

  10. Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 12:49

  11. Benni Mack merged patch set 4 11/09/26, 12:49