Review main Merged

97343[BUGFIX] Show empty input for unset page site setting

Georg Ringer CR +2 V +2 Easy +3 −3 updated 11/06/26, 08:13

Commit message

The page selection type of the site settings editor now renders an
empty input instead of "0" if no page is selected. Clearing the input
stores 0 again instead of sending NaN, which would have reset the
setting to its default.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 11/04/26, 16:08

  2. Georg Ringer commented on patch set 1 11/04/26, 16:09

    This change is ready for review.
  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 11/04/26, 16:11

  4. core-ci voted on patch set 1 V +1 11/04/26, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113298

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 11/04/26, 18:28

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/06/26, 00:54

  7. Georg Ringer voted on patch set 1 CR +2 V +2 11/06/26, 07:25

  8. Georg Ringer merged patch set 2 11/06/26, 08:13