97353[TASK] Fix PHPStan level 8 findings in extension scanner
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 26
- typo3/sysext/install/Classes/ExtensionScanner/Php/Visitor/GeneratorClassesResolver.php+2 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/AbstractMethodImplementationMatcherTest.php4+4 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassNameMatcherTest.php+2 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.php+10 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/FunctionCallMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodAnnotationMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcherTest.php+4 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+15 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyAnnotationMatcherTest.php+3 −1
Show 6 more files
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcherTest.php+8 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyProtectedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyPublicMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ScalarStringMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Visitor/CodeStatisticsTest.php+2 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Visitor/GeneratorClassesResolverTest.php+42 −4
Review log 1721
-
Simon Schaufelberger uploaded patch set 1 11/05/26, 01:14
-
Simon Schaufelberger commented on patch set 1 11/05/26, 01:16
The results of this Patch will be extracted into the standalone extension scanner which can be found here: https://github.com/simonschaufi/scanner/ -
core-ci voted on patch set 1 V +1 11/05/26, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113330
-
Oliver Klee commented on patch set 1 11/05/26, 10:50
AbstractMethodImplementationMatcherTest.php:36Can we make this more specific by checking for the specific type instead of for not-null? (Ditto for all other changes of the same type.) -
Simon Schaufelberger commented on patch set 1 11/05/26, 10:53
AbstractMethodImplementationMatcherTest.php:36Replycan you please make a suggestion what you would expect as I don't know what you mean? -
Oliver Klee commented on patch set 1 11/05/26, 11:11
AbstractMethodImplementationMatcherTest.php:36ReplyLike this (in this case): ```suggestion self::assertIsArray($statements, 'Code could not be parsed.'); ``` -
Simon Schaufelberger rebased onto patch set 2
V +111/05/26, 11:30 -
Simon Schaufelberger commented on patch set 2 11/05/26, 11:40
AbstractMethodImplementationMatcherTest.php:36ReplyDone -
Simon Schaufelberger uploaded patch set 3 11/05/26, 11:41
-
Oliver Klee voted on patch set 3 CR +1 V +1 11/05/26, 11:43
-
core-ci voted on patch set 3 V +1 11/05/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113397
-
Markus Klein voted on patch set 3 CR +1 V +1 11/05/26, 12:24
-
Simon Schaufelberger uploaded patch set 4
CR +1V +111/05/26, 13:18 -
core-ci voted on patch set 4 V +1 11/05/26, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113407
-
Oliver Klee voted on patch set 4 CR +1 V +1 11/05/26, 14:15
-
Simon Schaufelberger uploaded patch set 5
CR +1V +111/05/26, 16:31 -
core-ci voted on patch set 5 V +1 11/05/26, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113416
-
Oliver Klee voted on patch set 5 CR +1 V +1 11/05/26, 16:56
-
Garvin Hicking voted on patch set 5 CR +2 V +2 11/05/26, 23:10
-
Garvin Hicking merged patch set 6 11/05/26, 23:12
-
Simon Schaufelberger commented on patch set 6 11/08/26, 21:15
Reply
Done